1. Forum
  2. Fidonet
  3. SYNC PROGRAMMING

  • src/sbbs3/js_socket.c

    From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Tue Oct 4 14:28:50 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/f0127e9d4572f8c1c44536dc
    Modified Files:
    src/sbbs3/js_socket.c
    Log Message:
    Check socket writability in JS Socket.send()BINKP is suddenly frequently hanging on sendsocket() on Vertrauen on Windows(sending files to my Z1 hub) so try this as a solution.
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Mon Nov 28 11:03:39 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/3389aadcb8d3bcc3b428b993
    Modified Files:
    src/sbbs3/js_socket.c
    Log Message:
    Revert "Check socket writability in JS Socket.send()"This reverts commit f0127e9d4572f8c1c44536dcda240c310e18f7d8.This change was "wrong-headed" per Deuce and broke JS sends onblocking sockets. Thanks for the help.This fix for inifinite-wait on send() likely led to the infiniteBinkIT errors/log messages that led to commit 4dd32231.The real fix for this problem (which can block all other timedevents from running), would be a Socket.poll() on the socket beforesend in binkp.js.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)