Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 651709: Resource leaks (RESOURCE_LEAK)
/useredit.cpp: 108 in sbbs_t::useredit(int)()


_____________________________________________________________________________________________
*** CID 651709: Resource leaks (RESOURCE_LEAK)
/useredit.cpp: 108 in sbbs_t::useredit(int)()
102 if (user.comment[0] || i)
103 bprintf(text[UeditCommentLine], i ? '+' : ' ' 104 , user.comment);
105 else
106 term->newline();
107 if (localtime32(&user.laston, &tm) == NULL)

CID 651709: Resource leaks (RESOURCE_LEAK)
Variable "find_expr" going out of scope leaks the storage it points to. 108 return;

109 bprintf(text[UserDates]
110 , datestr(user.firston, str), datestr(user.expire, tmp)
111 , datestr(user.laston, tmp2), tm.tm_hour, tm.tm_min);
112
113 bprintf(text[UserTimes]


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



---
* Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 652885: Integer handling issues (INTEGER_OVERFLOW)
/useredit.cpp: 167 in sbbs_t::useredit(int)()


_____________________________________________________________________________________________
*** CID 652885: Integer handling issues (INTEGER_OVERFLOW) /useredit.cpp: 167 in sbbs_t::useredit(int)()
161 bprintf(text[UeditPrompt], user.number, l);
162 SAFEPRINTF4(str, "QG[]?/{}()%c%c%c%c", TERM_KEY_LEFT, TERM_KEY_RIGHT, TERM_KEY_HOME, TERM_KEY_END);
163 if (user.level <= useron.level)
164 SAFECAT(str, "ABCDEFHIJKLMNOPRSTUVWXYZ+~*$#"); 165 l = getkeys(str, l, K_UPPER | K_NOCRLF);
166 if (l & 0x80000000L) {

CID 652885: Integer handling issues (INTEGER_OVERFLOW)
Expression "user.number", where "l & 0xffffffff7fffffffL" is known to be equal to -2147483649, overflows the type of "user.number", which is type "int".

167 user.number = l & ~0x80000000L;
168 continue;
169 }
170 if (IS_ALPHA(l) || strchr("~+*$/", l) != NULL) // non-alpha commands that prompt
171 term->newline();
172 switch (l) {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



---
* Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 653403: Insecure data handling (INTEGER_OVERFLOW)
/userdat.c: 214 in total_users()


_____________________________________________________________________________________________
*** CID 653403: Insecure data handling (INTEGER_OVERFLOW)
/userdat.c: 214 in total_users()
208 lock is a synchronous round-trip that dominates the cost of this scan
209 when the data directory is network-mounted, and no amount of locking
210 makes the result more current than the snapshot it already is. */
211 do {
212 got = 0;
213 while (got < bufsize) {

CID 653403: Insecure data handling (INTEGER_OVERFLOW)
"64000UL - got", which might have underflowed, is passed to "read(file, buf + got, 64000UL - got)".

214 ssize_t rd = read(file, buf + got, bufsize - got);
215 if (rd <= 0)
216 break;
217 got += (size_t)rd;
218 }
219 for (size_t offset = 0; offset + USER_RECORD_LINE_LEN <= got; offset += USER_RECORD_LINE_LEN) {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



---
* Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net